dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
gimp/app/file-data/file-data.c

519 lines
26 KiB
C
Raw Normal View History

app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
/* GIMP - The GNU Image Manipulation Program
* Copyright (C) 1995 Spencer Kimball and Peter Mattis
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
#include "config.h"
#include <gdk-pixbuf/gdk-pixbuf.h>
#include <gegl.h>
#include "libgimpbase/gimpbase.h"
#include "core/core-types.h"
#include "core/gimp.h"
app: support saving/exporting with multi-selection. This commit just changes our saving API (i.e. the GimpSaveProcedure class) to take an array of drawables as argument instead of a single drawable. It actually doesn't matter much for exporting as the whole API seems more or less bogus there and all formats plug-ins mostly care only whether they will merge/flatten all visible layers (the selected ones don't really matter) or if the format supports layers of some sort. It may be worth later strengthening a bit this whole logics, and maybe allow partial exports for instance. As for saving, it was not even looking at the passed GimpDrawable either and was simply re-querying the active layer anyway. Note that I don't implement the multi-selection saving in XCF yet in this commit. I only updated the API. The reason is that the current commit won't be backportable to gimp-2-10 because it is an API break. On the other hand, the code to save multi-selection can still be backported even though the save() API will only pass a single drawable (as I said anyway, this argument was mostly bogus until now, hence it doesn't matter much for 2.10 logics).
2020-04-14 17:46:17 +08:00
#include "core/gimpdrawable.h"
app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
#include "core/gimpparamspecs.h"
#include "plug-in/gimppluginmanager.h"
#include "plug-in/gimppluginprocedure.h"
#include "file-data.h"
#include "file-data-gbr.h"
app: new "gex" format (GIMP Extension). File extension (.gex) may still change if anything better is proposed. This format is currently just a compressed archive containing the extension data (plug-in, brushes or whatever) and the metadata file. For now, opening such file will simply install it as a new extension, keeping all file permissions and structure. Of course in the future, it will have to trigger a confirmation dialog. Currently the compression used is zip, which is just a first draft. This is not a decisive choice as well. We could use some tarball compressed in whatever other compression algorithm. I use libarchive as a new dependency to support unarchiving as it seems to be a common library (and since it is already used by AppStream-glib anyway, this doesn't add any actual dependency, just make it direct).
2019-04-13 00:27:38 +08:00
#include "file-data-gex.h"
app, plug-ins: move file-gih-load from the file-gih plug-in to the core
2019-02-20 06:27:28 +08:00
#include "file-data-gih.h"
app: move file-pat-load from the file-pat plug-in to the core
2019-02-12 01:35:07 +08:00
#include "file-data-pat.h"
app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
#include "gimp-intl.h"
void
file_data_init (Gimp *gimp)
{
GimpPlugInProcedure *proc;
GFile *file;
GimpProcedure *procedure;
g_return_if_fail (GIMP_IS_GIMP (gimp));
/* file-gbr-load */
file = g_file_new_for_path ("file-gbr-load");
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure = gimp_plug_in_procedure_new (GIMP_PDB_PROC_TYPE_PLUGIN, file);
app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
g_object_unref (file);
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure->proc_type = GIMP_PDB_PROC_TYPE_INTERNAL;
app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
procedure->marshal_func = file_gbr_load_invoker;
proc = GIMP_PLUG_IN_PROCEDURE (procedure);
proc->menu_label = g_strdup (N_("GIMP brush"));
gimp_plug_in_procedure_set_icon (proc, GIMP_ICON_TYPE_ICON_NAME,
(const guint8 *) "gimp-brush",
pdb: move gimp_plugin_icon_register_invoker() from "plugin" to "pdb" and call it gimp_pdb_set_proc_icon(). Change icon registration code in libgimp/ and app/ so it's now possible to register icons for temporary procedures.
2019-09-08 22:22:32 +08:00
strlen ("gimp-brush") + 1,
NULL);
app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
gimp_plug_in_procedure_set_image_types (proc, NULL);
gimp_plug_in_procedure_set_file_proc (proc, "gbr, gbp", "",
"20, string, GIMP");
gimp_plug_in_procedure_set_mime_types (proc, "image/gimp-x-gbr");
Change the "handles uri" flag of file procedures to "handle remote" And always pass URIs to all file procedures, the ones what didn't register as "handles remove" will only ever get local file:// URIs. Change all file plug-ins (also legacy ones) to expect URIs instead of filenames, and convert to local paths in the plug-in. The wire protocol should now be almost 100% clean of non-UTF-8 strings.
2019-08-19 18:05:12 +08:00
gimp_plug_in_procedure_set_handles_remote (proc);
app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
gimp_object_set_static_name (GIMP_OBJECT (procedure), "file-gbr-load");
app, pdb: split GimpProcedure's "strings" into "help" and "attribution"
2019-09-09 05:40:34 +08:00
gimp_procedure_set_static_help (procedure,
"Loads GIMP brushes",
"Loads GIMP brushes (1 or 4 bpp "
"and old .gpb format)",
NULL);
gimp_procedure_set_static_attribution (procedure,
"Tim Newsome, Jens Lautenbacher, "
"Sven Neumann, Michael Natterer",
"Tim Newsome, Jens Lautenbacher, "
"Sven Neumann, Michael Natterer",
"1995-2019");
app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
app: move file-pat-load from the file-pat plug-in to the core
2019-02-12 01:35:07 +08:00
gimp_procedure_add_argument (procedure,
app, libgimp, libgimpbase: plug-in and PDB protocol refactoring part two - Change the wire protocol's GPProcInstall to transmit the entire information needed for constructing all GParamSpecs we use, don't use GimpPDBArgType in GPProcInstall but an enum private to the wire protocol plus the GParamSpec's GType name. Bump the wire protocol version. - Add gimpgpparamspecs.[ch] in both app/plug-in/ and libgimp/ which take care of converting between GPParamDef and GParamSpec. They share code as far as possible. - Change pluginrc writing and parsing to re-use GPParamDef and the utility functions from gimpgpparamspecs. - Remove gimp_pdb_compat_param_spec() from app/pdb/gimp-pdb-compat.[ch], the entire core uses proper GParamSpecs from the wire protocol now, the whole file will follow down the drain once we use a GValue representation on the wire too. - In gimp_plug_in_handle_proc_install(), change the "run-mode" parameter to a GParamSpecEnum(GIMP_TYPE_RUN_MODE) (if it is not already an enum). and change all places in app/ to treat it as an enum value. - plug-ins: fix cml-explorer to register correctly, a typo in "run-mode" was never noticed until now. - Add gimpgpcompat.[ch] in libgimp to deal with all the transforms between old-style wire communication and using GParamSpec and GValue, it contains some functions that are subject to change or even removal in the next steps. - Change the libgimp GimpProcedure and GimpPlugIn in many ways to be able to actually install procedures the new way. - plug-ins: change goat-exercise to completely use the new GimpPlugIn and GimpProcedure API, look here to see how plug-ins will look in the future, of course subject to change until this is finished. - Next: changing GPParam to transmit all information about a GValue.
2019-07-27 22:37:55 +08:00
gimp_param_spec_enum ("dummy-param",
"Dummy Param",
"Dummy parameter",
GIMP_TYPE_RUN_MODE,
GIMP_RUN_INTERACTIVE,
GIMP_PARAM_READWRITE));
app: move file-pat-load from the file-pat plug-in to the core
2019-02-12 01:35:07 +08:00
gimp_procedure_add_argument (procedure,
pdb, app, libgimp, plug-ins: replace most PDB filenames/URIs by GFile and in an attack of madness, changes almost all file plug-in code to use GFile instead of filenames, which means passing the GFile down to the bottom and get its filename at the very end where it's actually needed.
2019-09-12 03:48:34 +08:00
g_param_spec_object ("file",
"File",
"The file to load",
G_TYPE_FILE,
GIMP_PARAM_READWRITE));
app: move file-pat-load from the file-pat plug-in to the core
2019-02-12 01:35:07 +08:00
gimp_procedure_add_return_value (procedure,
app, libgimp: get rid of all ID GTypes and ID param specs Turn all ID param specs into object param specs (e.g. GimpParamImageID becomes GimpParamImage) and convert between IDs and objects in gimpgpparams.c directly above the the wire protocol, so all of app/, libgimp/ and plug-ins/ can deal directly with objects down to the lowest level and not care about IDs. Use the actual object param specs for procedure arguments and return values again instead of a plain g_param_spec_object() and bring back the none_ok parameter. This implies changing the PDB type checking functions to work on pure integers instead of IDs (one can't check whether object creation is possible if performing that check requires the object to already exist). For example gimp_foo_is_valid() becomes gimp_foo_id_is_valid() and is not involved in automatic object creation magic at the protocol level. Added wrappers which still say gimp_foo_is_valid() and take the respective objects. Adapted all code, and it all becomes nicer and less convoluted, even the generated PDB wrappers in app/ and libgimp/.
2019-08-29 17:25:35 +08:00
gimp_param_spec_image ("image",
"Image",
"Output image",
FALSE,
GIMP_PARAM_READWRITE));
app: move file-pat-load from the file-pat plug-in to the core
2019-02-12 01:35:07 +08:00
gimp_plug_in_manager_add_procedure (gimp->plug_in_manager, proc);
g_object_unref (procedure);
app, plug-ins: move brush (gbr) saving to the core just the export logic remains in the plug-in, just as for patterns.
2019-02-17 02:00:04 +08:00
/* file-gbr-save-internal */
file = g_file_new_for_path ("file-gbr-save-internal");
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure = gimp_plug_in_procedure_new (GIMP_PDB_PROC_TYPE_PLUGIN, file);
app, plug-ins: move brush (gbr) saving to the core just the export logic remains in the plug-in, just as for patterns.
2019-02-17 02:00:04 +08:00
g_object_unref (file);
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure->proc_type = GIMP_PDB_PROC_TYPE_INTERNAL;
app, plug-ins: move brush (gbr) saving to the core just the export logic remains in the plug-in, just as for patterns.
2019-02-17 02:00:04 +08:00
procedure->marshal_func = file_gbr_save_invoker;
proc = GIMP_PLUG_IN_PROCEDURE (procedure);
proc->menu_label = g_strdup (N_("GIMP brush"));
gimp_plug_in_procedure_set_icon (proc, GIMP_ICON_TYPE_ICON_NAME,
(const guint8 *) "gimp-brush",
pdb: move gimp_plugin_icon_register_invoker() from "plugin" to "pdb" and call it gimp_pdb_set_proc_icon(). Change icon registration code in libgimp/ and app/ so it's now possible to register icons for temporary procedures.
2019-09-08 22:22:32 +08:00
strlen ("gimp-brush") + 1,
NULL);
app, plug-ins: move brush (gbr) saving to the core just the export logic remains in the plug-in, just as for patterns.
2019-02-17 02:00:04 +08:00
#if 0
/* do not register as file procedure */
gimp_plug_in_procedure_set_image_types (proc, "RGB*, GRAY*, INDEXED*");
gimp_plug_in_procedure_set_file_proc (proc, "gbr", "", NULL);
gimp_plug_in_procedure_set_mime_types (proc, "image/x-gimp-gbr");
Change the "handles uri" flag of file procedures to "handle remote" And always pass URIs to all file procedures, the ones what didn't register as "handles remove" will only ever get local file:// URIs. Change all file plug-ins (also legacy ones) to expect URIs instead of filenames, and convert to local paths in the plug-in. The wire protocol should now be almost 100% clean of non-UTF-8 strings.
2019-08-19 18:05:12 +08:00
gimp_plug_in_procedure_set_handles_remote (proc);
app, plug-ins: move brush (gbr) saving to the core just the export logic remains in the plug-in, just as for patterns.
2019-02-17 02:00:04 +08:00
#endif
gimp_object_set_static_name (GIMP_OBJECT (procedure),
"file-gbr-save-internal");
app, pdb: split GimpProcedure's "strings" into "help" and "attribution"
2019-09-09 05:40:34 +08:00
gimp_procedure_set_static_help (procedure,
"Exports Gimp brush file (.GBR)",
"Exports Gimp brush file (.GBR)",
NULL);
gimp_procedure_set_static_attribution (procedure,
"Tim Newsome, Michael Natterer",
"Tim Newsome, Michael Natterer",
"1995-2019");
app, plug-ins: move brush (gbr) saving to the core just the export logic remains in the plug-in, just as for patterns.
2019-02-17 02:00:04 +08:00
gimp_procedure_add_argument (procedure,
app, libgimp, libgimpbase: plug-in and PDB protocol refactoring part two - Change the wire protocol's GPProcInstall to transmit the entire information needed for constructing all GParamSpecs we use, don't use GimpPDBArgType in GPProcInstall but an enum private to the wire protocol plus the GParamSpec's GType name. Bump the wire protocol version. - Add gimpgpparamspecs.[ch] in both app/plug-in/ and libgimp/ which take care of converting between GPParamDef and GParamSpec. They share code as far as possible. - Change pluginrc writing and parsing to re-use GPParamDef and the utility functions from gimpgpparamspecs. - Remove gimp_pdb_compat_param_spec() from app/pdb/gimp-pdb-compat.[ch], the entire core uses proper GParamSpecs from the wire protocol now, the whole file will follow down the drain once we use a GValue representation on the wire too. - In gimp_plug_in_handle_proc_install(), change the "run-mode" parameter to a GParamSpecEnum(GIMP_TYPE_RUN_MODE) (if it is not already an enum). and change all places in app/ to treat it as an enum value. - plug-ins: fix cml-explorer to register correctly, a typo in "run-mode" was never noticed until now. - Add gimpgpcompat.[ch] in libgimp to deal with all the transforms between old-style wire communication and using GParamSpec and GValue, it contains some functions that are subject to change or even removal in the next steps. - Change the libgimp GimpProcedure and GimpPlugIn in many ways to be able to actually install procedures the new way. - plug-ins: change goat-exercise to completely use the new GimpPlugIn and GimpProcedure API, look here to see how plug-ins will look in the future, of course subject to change until this is finished. - Next: changing GPParam to transmit all information about a GValue.
2019-07-27 22:37:55 +08:00
gimp_param_spec_enum ("dummy-param",
"Dummy Param",
"Dummy parameter",
GIMP_TYPE_RUN_MODE,
GIMP_RUN_INTERACTIVE,
GIMP_PARAM_READWRITE));
app, plug-ins: move brush (gbr) saving to the core just the export logic remains in the plug-in, just as for patterns.
2019-02-17 02:00:04 +08:00
gimp_procedure_add_argument (procedure,
app, libgimp: get rid of all ID GTypes and ID param specs Turn all ID param specs into object param specs (e.g. GimpParamImageID becomes GimpParamImage) and convert between IDs and objects in gimpgpparams.c directly above the the wire protocol, so all of app/, libgimp/ and plug-ins/ can deal directly with objects down to the lowest level and not care about IDs. Use the actual object param specs for procedure arguments and return values again instead of a plain g_param_spec_object() and bring back the none_ok parameter. This implies changing the PDB type checking functions to work on pure integers instead of IDs (one can't check whether object creation is possible if performing that check requires the object to already exist). For example gimp_foo_is_valid() becomes gimp_foo_id_is_valid() and is not involved in automatic object creation magic at the protocol level. Added wrappers which still say gimp_foo_is_valid() and take the respective objects. Adapted all code, and it all becomes nicer and less convoluted, even the generated PDB wrappers in app/ and libgimp/.
2019-08-29 17:25:35 +08:00
gimp_param_spec_image ("image",
"Image",
"Input image",
FALSE,
GIMP_PARAM_READWRITE));
app, plug-ins: move brush (gbr) saving to the core just the export logic remains in the plug-in, just as for patterns.
2019-02-17 02:00:04 +08:00
gimp_procedure_add_argument (procedure,
app, libgimp: get rid of all ID GTypes and ID param specs Turn all ID param specs into object param specs (e.g. GimpParamImageID becomes GimpParamImage) and convert between IDs and objects in gimpgpparams.c directly above the the wire protocol, so all of app/, libgimp/ and plug-ins/ can deal directly with objects down to the lowest level and not care about IDs. Use the actual object param specs for procedure arguments and return values again instead of a plain g_param_spec_object() and bring back the none_ok parameter. This implies changing the PDB type checking functions to work on pure integers instead of IDs (one can't check whether object creation is possible if performing that check requires the object to already exist). For example gimp_foo_is_valid() becomes gimp_foo_id_is_valid() and is not involved in automatic object creation magic at the protocol level. Added wrappers which still say gimp_foo_is_valid() and take the respective objects. Adapted all code, and it all becomes nicer and less convoluted, even the generated PDB wrappers in app/ and libgimp/.
2019-08-29 17:25:35 +08:00
gimp_param_spec_drawable ("drawable",
"Drawable",
"Active drawable "
"of input image",
FALSE,
GIMP_PARAM_READWRITE));
app, plug-ins: move brush (gbr) saving to the core just the export logic remains in the plug-in, just as for patterns.
2019-02-17 02:00:04 +08:00
gimp_procedure_add_argument (procedure,
pdb, app, libgimp, plug-ins: replace most PDB filenames/URIs by GFile and in an attack of madness, changes almost all file plug-in code to use GFile instead of filenames, which means passing the GFile down to the bottom and get its filename at the very end where it's actually needed.
2019-09-12 03:48:34 +08:00
g_param_spec_object ("file",
"File",
"The file to export",
G_TYPE_FILE,
GIMP_PARAM_READWRITE));
app, plug-ins: move brush (gbr) saving to the core just the export logic remains in the plug-in, just as for patterns.
2019-02-17 02:00:04 +08:00
gimp_procedure_add_argument (procedure,
Remove GIMP_TYPE_INT32 and GimpParamSpecInt32 Use gint and GParamSpecInt instead.
2019-08-15 20:04:56 +08:00
g_param_spec_int ("spacing",
"spacing",
"Spacing of the brush",
1, 1000, 10,
GIMP_PARAM_READWRITE));
app, plug-ins: move brush (gbr) saving to the core just the export logic remains in the plug-in, just as for patterns.
2019-02-17 02:00:04 +08:00
gimp_procedure_add_argument (procedure,
gimp_param_spec_string ("name",
"name",
"The name of the "
"brush",
FALSE, FALSE, TRUE,
"GIMP Brush",
GIMP_PARAM_READWRITE));
gimp_plug_in_manager_add_procedure (gimp->plug_in_manager, proc);
g_object_unref (procedure);
app, plug-ins: move file-gih-load from the file-gih plug-in to the core
2019-02-20 06:27:28 +08:00
/* file-gih-load */
file = g_file_new_for_path ("file-gih-load");
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure = gimp_plug_in_procedure_new (GIMP_PDB_PROC_TYPE_PLUGIN, file);
app, plug-ins: move file-gih-load from the file-gih plug-in to the core
2019-02-20 06:27:28 +08:00
g_object_unref (file);
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure->proc_type = GIMP_PDB_PROC_TYPE_INTERNAL;
app, plug-ins: move file-gih-load from the file-gih plug-in to the core
2019-02-20 06:27:28 +08:00
procedure->marshal_func = file_gih_load_invoker;
proc = GIMP_PLUG_IN_PROCEDURE (procedure);
proc->menu_label = g_strdup (N_("GIMP brush (animated)"));
gimp_plug_in_procedure_set_icon (proc, GIMP_ICON_TYPE_ICON_NAME,
(const guint8 *) "gimp-brush",
pdb: move gimp_plugin_icon_register_invoker() from "plugin" to "pdb" and call it gimp_pdb_set_proc_icon(). Change icon registration code in libgimp/ and app/ so it's now possible to register icons for temporary procedures.
2019-09-08 22:22:32 +08:00
strlen ("gimp-brush") + 1,
NULL);
app, plug-ins: move file-gih-load from the file-gih plug-in to the core
2019-02-20 06:27:28 +08:00
gimp_plug_in_procedure_set_image_types (proc, NULL);
gimp_plug_in_procedure_set_file_proc (proc, "gih", "", "");
gimp_plug_in_procedure_set_mime_types (proc, "image/gimp-x-gih");
Change the "handles uri" flag of file procedures to "handle remote" And always pass URIs to all file procedures, the ones what didn't register as "handles remove" will only ever get local file:// URIs. Change all file plug-ins (also legacy ones) to expect URIs instead of filenames, and convert to local paths in the plug-in. The wire protocol should now be almost 100% clean of non-UTF-8 strings.
2019-08-19 18:05:12 +08:00
gimp_plug_in_procedure_set_handles_remote (proc);
app, plug-ins: move file-gih-load from the file-gih plug-in to the core
2019-02-20 06:27:28 +08:00
gimp_object_set_static_name (GIMP_OBJECT (procedure), "file-gih-load");
app, pdb: split GimpProcedure's "strings" into "help" and "attribution"
2019-09-09 05:40:34 +08:00
gimp_procedure_set_static_help (procedure,
"Loads GIMP animated brushes",
"This procedure loads a GIMP brush "
"pipe as an image.",
NULL);
gimp_procedure_set_static_attribution (procedure,
"Tor Lillqvist, Michael Natterer",
"Tor Lillqvist, Michael Natterer",
"1999-2019");
app, plug-ins: move file-gih-load from the file-gih plug-in to the core
2019-02-20 06:27:28 +08:00
gimp_procedure_add_argument (procedure,
app, libgimp, libgimpbase: plug-in and PDB protocol refactoring part two - Change the wire protocol's GPProcInstall to transmit the entire information needed for constructing all GParamSpecs we use, don't use GimpPDBArgType in GPProcInstall but an enum private to the wire protocol plus the GParamSpec's GType name. Bump the wire protocol version. - Add gimpgpparamspecs.[ch] in both app/plug-in/ and libgimp/ which take care of converting between GPParamDef and GParamSpec. They share code as far as possible. - Change pluginrc writing and parsing to re-use GPParamDef and the utility functions from gimpgpparamspecs. - Remove gimp_pdb_compat_param_spec() from app/pdb/gimp-pdb-compat.[ch], the entire core uses proper GParamSpecs from the wire protocol now, the whole file will follow down the drain once we use a GValue representation on the wire too. - In gimp_plug_in_handle_proc_install(), change the "run-mode" parameter to a GParamSpecEnum(GIMP_TYPE_RUN_MODE) (if it is not already an enum). and change all places in app/ to treat it as an enum value. - plug-ins: fix cml-explorer to register correctly, a typo in "run-mode" was never noticed until now. - Add gimpgpcompat.[ch] in libgimp to deal with all the transforms between old-style wire communication and using GParamSpec and GValue, it contains some functions that are subject to change or even removal in the next steps. - Change the libgimp GimpProcedure and GimpPlugIn in many ways to be able to actually install procedures the new way. - plug-ins: change goat-exercise to completely use the new GimpPlugIn and GimpProcedure API, look here to see how plug-ins will look in the future, of course subject to change until this is finished. - Next: changing GPParam to transmit all information about a GValue.
2019-07-27 22:37:55 +08:00
gimp_param_spec_enum ("dummy-param",
"Dummy Param",
"Dummy parameter",
GIMP_TYPE_RUN_MODE,
GIMP_RUN_INTERACTIVE,
GIMP_PARAM_READWRITE));
app, plug-ins: move file-gih-load from the file-gih plug-in to the core
2019-02-20 06:27:28 +08:00
gimp_procedure_add_argument (procedure,
pdb, app, libgimp, plug-ins: replace most PDB filenames/URIs by GFile and in an attack of madness, changes almost all file plug-in code to use GFile instead of filenames, which means passing the GFile down to the bottom and get its filename at the very end where it's actually needed.
2019-09-12 03:48:34 +08:00
g_param_spec_object ("file",
"File",
"The file to load",
G_TYPE_FILE,
GIMP_PARAM_READWRITE));
app, plug-ins: move file-gih-load from the file-gih plug-in to the core
2019-02-20 06:27:28 +08:00
gimp_procedure_add_return_value (procedure,
app, libgimp: get rid of all ID GTypes and ID param specs Turn all ID param specs into object param specs (e.g. GimpParamImageID becomes GimpParamImage) and convert between IDs and objects in gimpgpparams.c directly above the the wire protocol, so all of app/, libgimp/ and plug-ins/ can deal directly with objects down to the lowest level and not care about IDs. Use the actual object param specs for procedure arguments and return values again instead of a plain g_param_spec_object() and bring back the none_ok parameter. This implies changing the PDB type checking functions to work on pure integers instead of IDs (one can't check whether object creation is possible if performing that check requires the object to already exist). For example gimp_foo_is_valid() becomes gimp_foo_id_is_valid() and is not involved in automatic object creation magic at the protocol level. Added wrappers which still say gimp_foo_is_valid() and take the respective objects. Adapted all code, and it all becomes nicer and less convoluted, even the generated PDB wrappers in app/ and libgimp/.
2019-08-29 17:25:35 +08:00
gimp_param_spec_image ("image",
"Image",
"Output image",
FALSE,
GIMP_PARAM_READWRITE));
app, plug-ins: move file-gih-load from the file-gih plug-in to the core
2019-02-20 06:27:28 +08:00
gimp_plug_in_manager_add_procedure (gimp->plug_in_manager, proc);
g_object_unref (procedure);
app, plug-ins: move brush pipe saving from the file-gih plug-in to the core As with .gbr and .pat, only the actual saving code, not the export logic and GUI.
2019-03-04 02:42:22 +08:00
/* file-gih-save-internal */
file = g_file_new_for_path ("file-gih-save-internal");
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure = gimp_plug_in_procedure_new (GIMP_PDB_PROC_TYPE_PLUGIN, file);
app, plug-ins: move brush pipe saving from the file-gih plug-in to the core As with .gbr and .pat, only the actual saving code, not the export logic and GUI.
2019-03-04 02:42:22 +08:00
g_object_unref (file);
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure->proc_type = GIMP_PDB_PROC_TYPE_INTERNAL;
app, plug-ins: move brush pipe saving from the file-gih plug-in to the core As with .gbr and .pat, only the actual saving code, not the export logic and GUI.
2019-03-04 02:42:22 +08:00
procedure->marshal_func = file_gih_save_invoker;
proc = GIMP_PLUG_IN_PROCEDURE (procedure);
proc->menu_label = g_strdup (N_("GIMP brush (animated)"));
gimp_plug_in_procedure_set_icon (proc, GIMP_ICON_TYPE_ICON_NAME,
(const guint8 *) "gimp-brush",
pdb: move gimp_plugin_icon_register_invoker() from "plugin" to "pdb" and call it gimp_pdb_set_proc_icon(). Change icon registration code in libgimp/ and app/ so it's now possible to register icons for temporary procedures.
2019-09-08 22:22:32 +08:00
strlen ("gimp-brush") + 1,
NULL);
app, plug-ins: move brush pipe saving from the file-gih plug-in to the core As with .gbr and .pat, only the actual saving code, not the export logic and GUI.
2019-03-04 02:42:22 +08:00
#if 0
/* do not register as file procedure */
gimp_plug_in_procedure_set_image_types (proc, "RGB*, GRAY*, INDEXED*");
gimp_plug_in_procedure_set_file_proc (proc, "gih", "", NULL);
gimp_plug_in_procedure_set_mime_types (proc, "image/x-gimp-gih");
Change the "handles uri" flag of file procedures to "handle remote" And always pass URIs to all file procedures, the ones what didn't register as "handles remove" will only ever get local file:// URIs. Change all file plug-ins (also legacy ones) to expect URIs instead of filenames, and convert to local paths in the plug-in. The wire protocol should now be almost 100% clean of non-UTF-8 strings.
2019-08-19 18:05:12 +08:00
gimp_plug_in_procedure_set_handles_remote (proc);
app, plug-ins: move brush pipe saving from the file-gih plug-in to the core As with .gbr and .pat, only the actual saving code, not the export logic and GUI.
2019-03-04 02:42:22 +08:00
#endif
gimp_object_set_static_name (GIMP_OBJECT (procedure),
"file-gih-save-internal");
app, pdb: split GimpProcedure's "strings" into "help" and "attribution"
2019-09-09 05:40:34 +08:00
gimp_procedure_set_static_help (procedure,
"Exports Gimp animated brush file (.gih)",
"Exports Gimp animated brush file (.gih)",
NULL);
gimp_procedure_set_static_attribution (procedure,
"Tor Lillqvist, Michael Natterer",
"Tor Lillqvist, Michael Natterer",
"1999-2019");
app, plug-ins: move brush pipe saving from the file-gih plug-in to the core As with .gbr and .pat, only the actual saving code, not the export logic and GUI.
2019-03-04 02:42:22 +08:00
gimp_procedure_add_argument (procedure,
app, libgimp, libgimpbase: plug-in and PDB protocol refactoring part two - Change the wire protocol's GPProcInstall to transmit the entire information needed for constructing all GParamSpecs we use, don't use GimpPDBArgType in GPProcInstall but an enum private to the wire protocol plus the GParamSpec's GType name. Bump the wire protocol version. - Add gimpgpparamspecs.[ch] in both app/plug-in/ and libgimp/ which take care of converting between GPParamDef and GParamSpec. They share code as far as possible. - Change pluginrc writing and parsing to re-use GPParamDef and the utility functions from gimpgpparamspecs. - Remove gimp_pdb_compat_param_spec() from app/pdb/gimp-pdb-compat.[ch], the entire core uses proper GParamSpecs from the wire protocol now, the whole file will follow down the drain once we use a GValue representation on the wire too. - In gimp_plug_in_handle_proc_install(), change the "run-mode" parameter to a GParamSpecEnum(GIMP_TYPE_RUN_MODE) (if it is not already an enum). and change all places in app/ to treat it as an enum value. - plug-ins: fix cml-explorer to register correctly, a typo in "run-mode" was never noticed until now. - Add gimpgpcompat.[ch] in libgimp to deal with all the transforms between old-style wire communication and using GParamSpec and GValue, it contains some functions that are subject to change or even removal in the next steps. - Change the libgimp GimpProcedure and GimpPlugIn in many ways to be able to actually install procedures the new way. - plug-ins: change goat-exercise to completely use the new GimpPlugIn and GimpProcedure API, look here to see how plug-ins will look in the future, of course subject to change until this is finished. - Next: changing GPParam to transmit all information about a GValue.
2019-07-27 22:37:55 +08:00
gimp_param_spec_enum ("dummy-param",
"Dummy Param",
"Dummy parameter",
GIMP_TYPE_RUN_MODE,
GIMP_RUN_INTERACTIVE,
GIMP_PARAM_READWRITE));
app, plug-ins: move brush pipe saving from the file-gih plug-in to the core As with .gbr and .pat, only the actual saving code, not the export logic and GUI.
2019-03-04 02:42:22 +08:00
gimp_procedure_add_argument (procedure,
app, libgimp: get rid of all ID GTypes and ID param specs Turn all ID param specs into object param specs (e.g. GimpParamImageID becomes GimpParamImage) and convert between IDs and objects in gimpgpparams.c directly above the the wire protocol, so all of app/, libgimp/ and plug-ins/ can deal directly with objects down to the lowest level and not care about IDs. Use the actual object param specs for procedure arguments and return values again instead of a plain g_param_spec_object() and bring back the none_ok parameter. This implies changing the PDB type checking functions to work on pure integers instead of IDs (one can't check whether object creation is possible if performing that check requires the object to already exist). For example gimp_foo_is_valid() becomes gimp_foo_id_is_valid() and is not involved in automatic object creation magic at the protocol level. Added wrappers which still say gimp_foo_is_valid() and take the respective objects. Adapted all code, and it all becomes nicer and less convoluted, even the generated PDB wrappers in app/ and libgimp/.
2019-08-29 17:25:35 +08:00
gimp_param_spec_image ("image",
"Image",
"Input image",
FALSE,
GIMP_PARAM_READWRITE));
app, plug-ins: move brush pipe saving from the file-gih plug-in to the core As with .gbr and .pat, only the actual saving code, not the export logic and GUI.
2019-03-04 02:42:22 +08:00
gimp_procedure_add_argument (procedure,
app: support saving/exporting with multi-selection. This commit just changes our saving API (i.e. the GimpSaveProcedure class) to take an array of drawables as argument instead of a single drawable. It actually doesn't matter much for exporting as the whole API seems more or less bogus there and all formats plug-ins mostly care only whether they will merge/flatten all visible layers (the selected ones don't really matter) or if the format supports layers of some sort. It may be worth later strengthening a bit this whole logics, and maybe allow partial exports for instance. As for saving, it was not even looking at the passed GimpDrawable either and was simply re-querying the active layer anyway. Note that I don't implement the multi-selection saving in XCF yet in this commit. I only updated the API. The reason is that the current commit won't be backportable to gimp-2-10 because it is an API break. On the other hand, the code to save multi-selection can still be backported even though the save() API will only pass a single drawable (as I said anyway, this argument was mostly bogus until now, hence it doesn't matter much for 2.10 logics).
2020-04-14 17:46:17 +08:00
g_param_spec_int ("num-drawables",
"num drawables",
"The number of drawables to save",
1, G_MAXINT32, 1,
GIMP_PARAM_READWRITE));
gimp_procedure_add_argument (procedure,
gimp_param_spec_object_array ("drawables",
"drawables",
"Drawables to save",
GIMP_TYPE_DRAWABLE,
GIMP_PARAM_READWRITE | GIMP_PARAM_NO_VALIDATE));
app, plug-ins: move brush pipe saving from the file-gih plug-in to the core As with .gbr and .pat, only the actual saving code, not the export logic and GUI.
2019-03-04 02:42:22 +08:00
gimp_procedure_add_argument (procedure,
pdb, app, libgimp, plug-ins: replace most PDB filenames/URIs by GFile and in an attack of madness, changes almost all file plug-in code to use GFile instead of filenames, which means passing the GFile down to the bottom and get its filename at the very end where it's actually needed.
2019-09-12 03:48:34 +08:00
g_param_spec_object ("file",
"File",
"The file to export",
G_TYPE_FILE,
GIMP_PARAM_READWRITE));
app, plug-ins: move brush pipe saving from the file-gih plug-in to the core As with .gbr and .pat, only the actual saving code, not the export logic and GUI.
2019-03-04 02:42:22 +08:00
gimp_procedure_add_argument (procedure,
Remove GIMP_TYPE_INT32 and GimpParamSpecInt32 Use gint and GParamSpecInt instead.
2019-08-15 20:04:56 +08:00
g_param_spec_int ("spacing",
"spacing",
"Spacing of the brush",
1, 1000, 10,
GIMP_PARAM_READWRITE));
app, plug-ins: move brush pipe saving from the file-gih plug-in to the core As with .gbr and .pat, only the actual saving code, not the export logic and GUI.
2019-03-04 02:42:22 +08:00
gimp_procedure_add_argument (procedure,
gimp_param_spec_string ("name",
"name",
"The name of the "
"brush",
FALSE, FALSE, TRUE,
"GIMP Brush",
GIMP_PARAM_READWRITE));
gimp_procedure_add_argument (procedure,
gimp_param_spec_string ("params",
"params",
"The pipe's parameters",
FALSE, FALSE, TRUE,
NULL,
GIMP_PARAM_READWRITE));
gimp_plug_in_manager_add_procedure (gimp->plug_in_manager, proc);
g_object_unref (procedure);
app: move file-pat-load from the file-pat plug-in to the core
2019-02-12 01:35:07 +08:00
/* file-pat-load */
file = g_file_new_for_path ("file-pat-load");
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure = gimp_plug_in_procedure_new (GIMP_PDB_PROC_TYPE_PLUGIN, file);
app: move file-pat-load from the file-pat plug-in to the core
2019-02-12 01:35:07 +08:00
g_object_unref (file);
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure->proc_type = GIMP_PDB_PROC_TYPE_INTERNAL;
app: move file-pat-load from the file-pat plug-in to the core
2019-02-12 01:35:07 +08:00
procedure->marshal_func = file_pat_load_invoker;
proc = GIMP_PLUG_IN_PROCEDURE (procedure);
proc->menu_label = g_strdup (N_("GIMP pattern"));
gimp_plug_in_procedure_set_icon (proc, GIMP_ICON_TYPE_ICON_NAME,
(const guint8 *) "gimp-pattern",
pdb: move gimp_plugin_icon_register_invoker() from "plugin" to "pdb" and call it gimp_pdb_set_proc_icon(). Change icon registration code in libgimp/ and app/ so it's now possible to register icons for temporary procedures.
2019-09-08 22:22:32 +08:00
strlen ("gimp-pattern") + 1,
NULL);
app: move file-pat-load from the file-pat plug-in to the core
2019-02-12 01:35:07 +08:00
gimp_plug_in_procedure_set_image_types (proc, NULL);
gimp_plug_in_procedure_set_file_proc (proc, "pat", "",
"20,string,GPAT");
gimp_plug_in_procedure_set_mime_types (proc, "image/gimp-x-pat");
Change the "handles uri" flag of file procedures to "handle remote" And always pass URIs to all file procedures, the ones what didn't register as "handles remove" will only ever get local file:// URIs. Change all file plug-ins (also legacy ones) to expect URIs instead of filenames, and convert to local paths in the plug-in. The wire protocol should now be almost 100% clean of non-UTF-8 strings.
2019-08-19 18:05:12 +08:00
gimp_plug_in_procedure_set_handles_remote (proc);
app: move file-pat-load from the file-pat plug-in to the core
2019-02-12 01:35:07 +08:00
gimp_object_set_static_name (GIMP_OBJECT (procedure), "file-pat-load");
app, pdb: split GimpProcedure's "strings" into "help" and "attribution"
2019-09-09 05:40:34 +08:00
gimp_procedure_set_static_help (procedure,
"Loads GIMP patterns",
"Loads GIMP patterns",
NULL);
gimp_procedure_set_static_attribution (procedure,
"Tim Newsome, Michael Natterer",
"Tim Newsome, Michael Natterer",
"1997-2019");
app: move file-pat-load from the file-pat plug-in to the core
2019-02-12 01:35:07 +08:00
app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
gimp_procedure_add_argument (procedure,
app, libgimp, libgimpbase: plug-in and PDB protocol refactoring part two - Change the wire protocol's GPProcInstall to transmit the entire information needed for constructing all GParamSpecs we use, don't use GimpPDBArgType in GPProcInstall but an enum private to the wire protocol plus the GParamSpec's GType name. Bump the wire protocol version. - Add gimpgpparamspecs.[ch] in both app/plug-in/ and libgimp/ which take care of converting between GPParamDef and GParamSpec. They share code as far as possible. - Change pluginrc writing and parsing to re-use GPParamDef and the utility functions from gimpgpparamspecs. - Remove gimp_pdb_compat_param_spec() from app/pdb/gimp-pdb-compat.[ch], the entire core uses proper GParamSpecs from the wire protocol now, the whole file will follow down the drain once we use a GValue representation on the wire too. - In gimp_plug_in_handle_proc_install(), change the "run-mode" parameter to a GParamSpecEnum(GIMP_TYPE_RUN_MODE) (if it is not already an enum). and change all places in app/ to treat it as an enum value. - plug-ins: fix cml-explorer to register correctly, a typo in "run-mode" was never noticed until now. - Add gimpgpcompat.[ch] in libgimp to deal with all the transforms between old-style wire communication and using GParamSpec and GValue, it contains some functions that are subject to change or even removal in the next steps. - Change the libgimp GimpProcedure and GimpPlugIn in many ways to be able to actually install procedures the new way. - plug-ins: change goat-exercise to completely use the new GimpPlugIn and GimpProcedure API, look here to see how plug-ins will look in the future, of course subject to change until this is finished. - Next: changing GPParam to transmit all information about a GValue.
2019-07-27 22:37:55 +08:00
gimp_param_spec_enum ("dummy-param",
"Dummy Param",
"Dummy parameter",
GIMP_TYPE_RUN_MODE,
GIMP_RUN_INTERACTIVE,
GIMP_PARAM_READWRITE));
app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
gimp_procedure_add_argument (procedure,
pdb, app, libgimp, plug-ins: replace most PDB filenames/URIs by GFile and in an attack of madness, changes almost all file plug-in code to use GFile instead of filenames, which means passing the GFile down to the bottom and get its filename at the very end where it's actually needed.
2019-09-12 03:48:34 +08:00
g_param_spec_object ("file",
"File",
"The file to load",
G_TYPE_FILE,
GIMP_PARAM_READWRITE));
app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
gimp_procedure_add_return_value (procedure,
app, libgimp: get rid of all ID GTypes and ID param specs Turn all ID param specs into object param specs (e.g. GimpParamImageID becomes GimpParamImage) and convert between IDs and objects in gimpgpparams.c directly above the the wire protocol, so all of app/, libgimp/ and plug-ins/ can deal directly with objects down to the lowest level and not care about IDs. Use the actual object param specs for procedure arguments and return values again instead of a plain g_param_spec_object() and bring back the none_ok parameter. This implies changing the PDB type checking functions to work on pure integers instead of IDs (one can't check whether object creation is possible if performing that check requires the object to already exist). For example gimp_foo_is_valid() becomes gimp_foo_id_is_valid() and is not involved in automatic object creation magic at the protocol level. Added wrappers which still say gimp_foo_is_valid() and take the respective objects. Adapted all code, and it all becomes nicer and less convoluted, even the generated PDB wrappers in app/ and libgimp/.
2019-08-29 17:25:35 +08:00
gimp_param_spec_image ("image",
"Image",
"Output image",
FALSE,
GIMP_PARAM_READWRITE));
app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
gimp_plug_in_manager_add_procedure (gimp->plug_in_manager, proc);
g_object_unref (procedure);
app, plug-ins: move pattern saving to the core but only the actual saving code, not the export magic and dialog. Add new internal procedure file-pat-save-internal which is not registered as a file procedure and always works non-interactively on the passed arguments and only saves the passed drawable. Use the new internal procedure from the file-pat-save code and remove all file writing code from the plug-in. This way all pattern file writing code duplication is killed, while the whole export mechanism is completely unchanged.
2019-02-13 04:27:13 +08:00
/* file-pat-save-internal */
file = g_file_new_for_path ("file-pat-save-internal");
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure = gimp_plug_in_procedure_new (GIMP_PDB_PROC_TYPE_PLUGIN, file);
app, plug-ins: move pattern saving to the core but only the actual saving code, not the export magic and dialog. Add new internal procedure file-pat-save-internal which is not registered as a file procedure and always works non-interactively on the passed arguments and only saves the passed drawable. Use the new internal procedure from the file-pat-save code and remove all file writing code from the plug-in. This way all pattern file writing code duplication is killed, while the whole export mechanism is completely unchanged.
2019-02-13 04:27:13 +08:00
g_object_unref (file);
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure->proc_type = GIMP_PDB_PROC_TYPE_INTERNAL;
app, plug-ins: move pattern saving to the core but only the actual saving code, not the export magic and dialog. Add new internal procedure file-pat-save-internal which is not registered as a file procedure and always works non-interactively on the passed arguments and only saves the passed drawable. Use the new internal procedure from the file-pat-save code and remove all file writing code from the plug-in. This way all pattern file writing code duplication is killed, while the whole export mechanism is completely unchanged.
2019-02-13 04:27:13 +08:00
procedure->marshal_func = file_pat_save_invoker;
proc = GIMP_PLUG_IN_PROCEDURE (procedure);
proc->menu_label = g_strdup (N_("GIMP pattern"));
gimp_plug_in_procedure_set_icon (proc, GIMP_ICON_TYPE_ICON_NAME,
(const guint8 *) "gimp-pattern",
pdb: move gimp_plugin_icon_register_invoker() from "plugin" to "pdb" and call it gimp_pdb_set_proc_icon(). Change icon registration code in libgimp/ and app/ so it's now possible to register icons for temporary procedures.
2019-09-08 22:22:32 +08:00
strlen ("gimp-pattern") + 1,
NULL);
app, plug-ins: move pattern saving to the core but only the actual saving code, not the export magic and dialog. Add new internal procedure file-pat-save-internal which is not registered as a file procedure and always works non-interactively on the passed arguments and only saves the passed drawable. Use the new internal procedure from the file-pat-save code and remove all file writing code from the plug-in. This way all pattern file writing code duplication is killed, while the whole export mechanism is completely unchanged.
2019-02-13 04:27:13 +08:00
#if 0
/* do not register as file procedure */
gimp_plug_in_procedure_set_image_types (proc, "RGB*, GRAY*, INDEXED*");
gimp_plug_in_procedure_set_file_proc (proc, "pat", "", NULL);
gimp_plug_in_procedure_set_mime_types (proc, "image/x-gimp-pat");
Change the "handles uri" flag of file procedures to "handle remote" And always pass URIs to all file procedures, the ones what didn't register as "handles remove" will only ever get local file:// URIs. Change all file plug-ins (also legacy ones) to expect URIs instead of filenames, and convert to local paths in the plug-in. The wire protocol should now be almost 100% clean of non-UTF-8 strings.
2019-08-19 18:05:12 +08:00
gimp_plug_in_procedure_set_handles_remote (proc);
app, plug-ins: move pattern saving to the core but only the actual saving code, not the export magic and dialog. Add new internal procedure file-pat-save-internal which is not registered as a file procedure and always works non-interactively on the passed arguments and only saves the passed drawable. Use the new internal procedure from the file-pat-save code and remove all file writing code from the plug-in. This way all pattern file writing code duplication is killed, while the whole export mechanism is completely unchanged.
2019-02-13 04:27:13 +08:00
#endif
gimp_object_set_static_name (GIMP_OBJECT (procedure),
"file-pat-save-internal");
app, pdb: split GimpProcedure's "strings" into "help" and "attribution"
2019-09-09 05:40:34 +08:00
gimp_procedure_set_static_help (procedure,
"Exports Gimp pattern file (.PAT)",
"Exports Gimp pattern file (.PAT)",
NULL);
gimp_procedure_set_static_attribution (procedure,
"Tim Newsome, Michael Natterer",
"Tim Newsome, Michael Natterer",
"1995-2019");
app, plug-ins: move pattern saving to the core but only the actual saving code, not the export magic and dialog. Add new internal procedure file-pat-save-internal which is not registered as a file procedure and always works non-interactively on the passed arguments and only saves the passed drawable. Use the new internal procedure from the file-pat-save code and remove all file writing code from the plug-in. This way all pattern file writing code duplication is killed, while the whole export mechanism is completely unchanged.
2019-02-13 04:27:13 +08:00
gimp_procedure_add_argument (procedure,
app, libgimp, libgimpbase: plug-in and PDB protocol refactoring part two - Change the wire protocol's GPProcInstall to transmit the entire information needed for constructing all GParamSpecs we use, don't use GimpPDBArgType in GPProcInstall but an enum private to the wire protocol plus the GParamSpec's GType name. Bump the wire protocol version. - Add gimpgpparamspecs.[ch] in both app/plug-in/ and libgimp/ which take care of converting between GPParamDef and GParamSpec. They share code as far as possible. - Change pluginrc writing and parsing to re-use GPParamDef and the utility functions from gimpgpparamspecs. - Remove gimp_pdb_compat_param_spec() from app/pdb/gimp-pdb-compat.[ch], the entire core uses proper GParamSpecs from the wire protocol now, the whole file will follow down the drain once we use a GValue representation on the wire too. - In gimp_plug_in_handle_proc_install(), change the "run-mode" parameter to a GParamSpecEnum(GIMP_TYPE_RUN_MODE) (if it is not already an enum). and change all places in app/ to treat it as an enum value. - plug-ins: fix cml-explorer to register correctly, a typo in "run-mode" was never noticed until now. - Add gimpgpcompat.[ch] in libgimp to deal with all the transforms between old-style wire communication and using GParamSpec and GValue, it contains some functions that are subject to change or even removal in the next steps. - Change the libgimp GimpProcedure and GimpPlugIn in many ways to be able to actually install procedures the new way. - plug-ins: change goat-exercise to completely use the new GimpPlugIn and GimpProcedure API, look here to see how plug-ins will look in the future, of course subject to change until this is finished. - Next: changing GPParam to transmit all information about a GValue.
2019-07-27 22:37:55 +08:00
gimp_param_spec_enum ("dummy-param",
"Dummy Param",
"Dummy parameter",
GIMP_TYPE_RUN_MODE,
GIMP_RUN_INTERACTIVE,
GIMP_PARAM_READWRITE));
app, plug-ins: move pattern saving to the core but only the actual saving code, not the export magic and dialog. Add new internal procedure file-pat-save-internal which is not registered as a file procedure and always works non-interactively on the passed arguments and only saves the passed drawable. Use the new internal procedure from the file-pat-save code and remove all file writing code from the plug-in. This way all pattern file writing code duplication is killed, while the whole export mechanism is completely unchanged.
2019-02-13 04:27:13 +08:00
gimp_procedure_add_argument (procedure,
app, libgimp: get rid of all ID GTypes and ID param specs Turn all ID param specs into object param specs (e.g. GimpParamImageID becomes GimpParamImage) and convert between IDs and objects in gimpgpparams.c directly above the the wire protocol, so all of app/, libgimp/ and plug-ins/ can deal directly with objects down to the lowest level and not care about IDs. Use the actual object param specs for procedure arguments and return values again instead of a plain g_param_spec_object() and bring back the none_ok parameter. This implies changing the PDB type checking functions to work on pure integers instead of IDs (one can't check whether object creation is possible if performing that check requires the object to already exist). For example gimp_foo_is_valid() becomes gimp_foo_id_is_valid() and is not involved in automatic object creation magic at the protocol level. Added wrappers which still say gimp_foo_is_valid() and take the respective objects. Adapted all code, and it all becomes nicer and less convoluted, even the generated PDB wrappers in app/ and libgimp/.
2019-08-29 17:25:35 +08:00
gimp_param_spec_image ("image",
"Image",
"Input image",
FALSE,
GIMP_PARAM_READWRITE));
app, plug-ins: move pattern saving to the core but only the actual saving code, not the export magic and dialog. Add new internal procedure file-pat-save-internal which is not registered as a file procedure and always works non-interactively on the passed arguments and only saves the passed drawable. Use the new internal procedure from the file-pat-save code and remove all file writing code from the plug-in. This way all pattern file writing code duplication is killed, while the whole export mechanism is completely unchanged.
2019-02-13 04:27:13 +08:00
gimp_procedure_add_argument (procedure,
Issue #5313: consistent "file-pat-save-internal" procedure with… … multiple drawables as parameter. Previous commit 7bb892f3 was "making it work" by making the API inconsistent and also only using the first drawable, which is making the logics meaningless. Instead accept multiple drawables, and export only the selected drawable (when alone) or the merged-down image containing only the selected drawables (when many). Note that in current implementation, this is not useful from GUI calls because the fully merged image is always exported when run interactively or with last vals (i.e. from the GUI) because gimp_export_image() flattens the image. So this change would only work when called non-interactively from other plug-ins. In such a case, multi-layer images do no longer return an error and whatever items are selected would change the export result. See also #7370 for a discussion about how to handle the selected items during export (because currently the `drawables` parameter of GimpSaveProcedure's run function is clearly a mostly bogus parameter).
2021-10-15 05:48:36 +08:00
g_param_spec_int ("n-drawables",
"Num drawables",
"Number of drawables",
1, G_MAXINT, 1,
GIMP_PARAM_READWRITE));
gimp_procedure_add_argument (procedure,
gimp_param_spec_object_array ("drawables",
"Drawables",
"Selected drawables",
GIMP_TYPE_DRAWABLE,
GIMP_PARAM_READWRITE | GIMP_PARAM_NO_VALIDATE));
app, plug-ins: move pattern saving to the core but only the actual saving code, not the export magic and dialog. Add new internal procedure file-pat-save-internal which is not registered as a file procedure and always works non-interactively on the passed arguments and only saves the passed drawable. Use the new internal procedure from the file-pat-save code and remove all file writing code from the plug-in. This way all pattern file writing code duplication is killed, while the whole export mechanism is completely unchanged.
2019-02-13 04:27:13 +08:00
gimp_procedure_add_argument (procedure,
pdb, app, libgimp, plug-ins: replace most PDB filenames/URIs by GFile and in an attack of madness, changes almost all file plug-in code to use GFile instead of filenames, which means passing the GFile down to the bottom and get its filename at the very end where it's actually needed.
2019-09-12 03:48:34 +08:00
g_param_spec_object ("file",
"File",
"The file to export",
G_TYPE_FILE,
GIMP_PARAM_READWRITE));
app, plug-ins: move pattern saving to the core but only the actual saving code, not the export magic and dialog. Add new internal procedure file-pat-save-internal which is not registered as a file procedure and always works non-interactively on the passed arguments and only saves the passed drawable. Use the new internal procedure from the file-pat-save code and remove all file writing code from the plug-in. This way all pattern file writing code duplication is killed, while the whole export mechanism is completely unchanged.
2019-02-13 04:27:13 +08:00
gimp_procedure_add_argument (procedure,
gimp_param_spec_string ("name",
"name",
"The name of the "
"pattern",
FALSE, FALSE, TRUE,
"GIMP Pattern",
GIMP_PARAM_READWRITE));
gimp_plug_in_manager_add_procedure (gimp->plug_in_manager, proc);
g_object_unref (procedure);
app: new "gex" format (GIMP Extension). File extension (.gex) may still change if anything better is proposed. This format is currently just a compressed archive containing the extension data (plug-in, brushes or whatever) and the metadata file. For now, opening such file will simply install it as a new extension, keeping all file permissions and structure. Of course in the future, it will have to trigger a confirmation dialog. Currently the compression used is zip, which is just a first draft. This is not a decisive choice as well. We could use some tarball compressed in whatever other compression algorithm. I use libarchive as a new dependency to support unarchiving as it seems to be a common library (and since it is already used by AppStream-glib anyway, this doesn't add any actual dependency, just make it direct).
2019-04-13 00:27:38 +08:00
/* file-gex-load */
file = g_file_new_for_path ("file-gex-load");
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure = gimp_plug_in_procedure_new (GIMP_PDB_PROC_TYPE_PLUGIN, file);
app: new "gex" format (GIMP Extension). File extension (.gex) may still change if anything better is proposed. This format is currently just a compressed archive containing the extension data (plug-in, brushes or whatever) and the metadata file. For now, opening such file will simply install it as a new extension, keeping all file permissions and structure. Of course in the future, it will have to trigger a confirmation dialog. Currently the compression used is zip, which is just a first draft. This is not a decisive choice as well. We could use some tarball compressed in whatever other compression algorithm. I use libarchive as a new dependency to support unarchiving as it seems to be a common library (and since it is already used by AppStream-glib anyway, this doesn't add any actual dependency, just make it direct).
2019-04-13 00:27:38 +08:00
g_object_unref (file);
Properly prefix the values of enum GimpPDBProcType to be GIMP_PDB_PROC_TYPE_PLUGIN, _EXTENSION etc.
2019-08-30 18:52:28 +08:00
procedure->proc_type = GIMP_PDB_PROC_TYPE_INTERNAL;
app: new "gex" format (GIMP Extension). File extension (.gex) may still change if anything better is proposed. This format is currently just a compressed archive containing the extension data (plug-in, brushes or whatever) and the metadata file. For now, opening such file will simply install it as a new extension, keeping all file permissions and structure. Of course in the future, it will have to trigger a confirmation dialog. Currently the compression used is zip, which is just a first draft. This is not a decisive choice as well. We could use some tarball compressed in whatever other compression algorithm. I use libarchive as a new dependency to support unarchiving as it seems to be a common library (and since it is already used by AppStream-glib anyway, this doesn't add any actual dependency, just make it direct).
2019-04-13 00:27:38 +08:00
procedure->marshal_func = file_gex_load_invoker;
proc = GIMP_PLUG_IN_PROCEDURE (procedure);
proc->menu_label = g_strdup (N_("GIMP extension"));
gimp_plug_in_procedure_set_icon (proc, GIMP_ICON_TYPE_ICON_NAME,
(const guint8 *) "gimp-plugin",
pdb: move gimp_plugin_icon_register_invoker() from "plugin" to "pdb" and call it gimp_pdb_set_proc_icon(). Change icon registration code in libgimp/ and app/ so it's now possible to register icons for temporary procedures.
2019-09-08 22:22:32 +08:00
strlen ("gimp-plugin") + 1,
NULL);
app: new "gex" format (GIMP Extension). File extension (.gex) may still change if anything better is proposed. This format is currently just a compressed archive containing the extension data (plug-in, brushes or whatever) and the metadata file. For now, opening such file will simply install it as a new extension, keeping all file permissions and structure. Of course in the future, it will have to trigger a confirmation dialog. Currently the compression used is zip, which is just a first draft. This is not a decisive choice as well. We could use some tarball compressed in whatever other compression algorithm. I use libarchive as a new dependency to support unarchiving as it seems to be a common library (and since it is already used by AppStream-glib anyway, this doesn't add any actual dependency, just make it direct).
2019-04-13 00:27:38 +08:00
gimp_plug_in_procedure_set_file_proc (proc, "gex", "",
"20, string, GIMP");
gimp_plug_in_procedure_set_generic_file_proc (proc, TRUE);
gimp_plug_in_procedure_set_mime_types (proc, "image/gimp-x-gex");
Change the "handles uri" flag of file procedures to "handle remote" And always pass URIs to all file procedures, the ones what didn't register as "handles remove" will only ever get local file:// URIs. Change all file plug-ins (also legacy ones) to expect URIs instead of filenames, and convert to local paths in the plug-in. The wire protocol should now be almost 100% clean of non-UTF-8 strings.
2019-08-19 18:05:12 +08:00
gimp_plug_in_procedure_set_handles_remote (proc);
app: new "gex" format (GIMP Extension). File extension (.gex) may still change if anything better is proposed. This format is currently just a compressed archive containing the extension data (plug-in, brushes or whatever) and the metadata file. For now, opening such file will simply install it as a new extension, keeping all file permissions and structure. Of course in the future, it will have to trigger a confirmation dialog. Currently the compression used is zip, which is just a first draft. This is not a decisive choice as well. We could use some tarball compressed in whatever other compression algorithm. I use libarchive as a new dependency to support unarchiving as it seems to be a common library (and since it is already used by AppStream-glib anyway, this doesn't add any actual dependency, just make it direct).
2019-04-13 00:27:38 +08:00
gimp_object_set_static_name (GIMP_OBJECT (procedure), "file-gex-load");
app, pdb: split GimpProcedure's "strings" into "help" and "attribution"
2019-09-09 05:40:34 +08:00
gimp_procedure_set_static_help (procedure,
"Loads GIMP extension",
"Loads GIMP extension",
NULL);
gimp_procedure_set_static_attribution (procedure,
"Jehan", "Jehan", "2019");
app: new "gex" format (GIMP Extension). File extension (.gex) may still change if anything better is proposed. This format is currently just a compressed archive containing the extension data (plug-in, brushes or whatever) and the metadata file. For now, opening such file will simply install it as a new extension, keeping all file permissions and structure. Of course in the future, it will have to trigger a confirmation dialog. Currently the compression used is zip, which is just a first draft. This is not a decisive choice as well. We could use some tarball compressed in whatever other compression algorithm. I use libarchive as a new dependency to support unarchiving as it seems to be a common library (and since it is already used by AppStream-glib anyway, this doesn't add any actual dependency, just make it direct).
2019-04-13 00:27:38 +08:00
gimp_procedure_add_argument (procedure,
app, libgimp, libgimpbase: plug-in and PDB protocol refactoring part two - Change the wire protocol's GPProcInstall to transmit the entire information needed for constructing all GParamSpecs we use, don't use GimpPDBArgType in GPProcInstall but an enum private to the wire protocol plus the GParamSpec's GType name. Bump the wire protocol version. - Add gimpgpparamspecs.[ch] in both app/plug-in/ and libgimp/ which take care of converting between GPParamDef and GParamSpec. They share code as far as possible. - Change pluginrc writing and parsing to re-use GPParamDef and the utility functions from gimpgpparamspecs. - Remove gimp_pdb_compat_param_spec() from app/pdb/gimp-pdb-compat.[ch], the entire core uses proper GParamSpecs from the wire protocol now, the whole file will follow down the drain once we use a GValue representation on the wire too. - In gimp_plug_in_handle_proc_install(), change the "run-mode" parameter to a GParamSpecEnum(GIMP_TYPE_RUN_MODE) (if it is not already an enum). and change all places in app/ to treat it as an enum value. - plug-ins: fix cml-explorer to register correctly, a typo in "run-mode" was never noticed until now. - Add gimpgpcompat.[ch] in libgimp to deal with all the transforms between old-style wire communication and using GParamSpec and GValue, it contains some functions that are subject to change or even removal in the next steps. - Change the libgimp GimpProcedure and GimpPlugIn in many ways to be able to actually install procedures the new way. - plug-ins: change goat-exercise to completely use the new GimpPlugIn and GimpProcedure API, look here to see how plug-ins will look in the future, of course subject to change until this is finished. - Next: changing GPParam to transmit all information about a GValue.
2019-07-27 22:37:55 +08:00
gimp_param_spec_enum ("dummy-param",
"Dummy Param",
"Dummy parameter",
GIMP_TYPE_RUN_MODE,
GIMP_RUN_INTERACTIVE,
GIMP_PARAM_READWRITE));
app: new "gex" format (GIMP Extension). File extension (.gex) may still change if anything better is proposed. This format is currently just a compressed archive containing the extension data (plug-in, brushes or whatever) and the metadata file. For now, opening such file will simply install it as a new extension, keeping all file permissions and structure. Of course in the future, it will have to trigger a confirmation dialog. Currently the compression used is zip, which is just a first draft. This is not a decisive choice as well. We could use some tarball compressed in whatever other compression algorithm. I use libarchive as a new dependency to support unarchiving as it seems to be a common library (and since it is already used by AppStream-glib anyway, this doesn't add any actual dependency, just make it direct).
2019-04-13 00:27:38 +08:00
gimp_procedure_add_argument (procedure,
pdb, app, libgimp, plug-ins: replace most PDB filenames/URIs by GFile and in an attack of madness, changes almost all file plug-in code to use GFile instead of filenames, which means passing the GFile down to the bottom and get its filename at the very end where it's actually needed.
2019-09-12 03:48:34 +08:00
g_param_spec_object ("file",
"File",
"The file to load",
G_TYPE_FILE,
GIMP_PARAM_READWRITE));
app: new "gex" format (GIMP Extension). File extension (.gex) may still change if anything better is proposed. This format is currently just a compressed archive containing the extension data (plug-in, brushes or whatever) and the metadata file. For now, opening such file will simply install it as a new extension, keeping all file permissions and structure. Of course in the future, it will have to trigger a confirmation dialog. Currently the compression used is zip, which is just a first draft. This is not a decisive choice as well. We could use some tarball compressed in whatever other compression algorithm. I use libarchive as a new dependency to support unarchiving as it seems to be a common library (and since it is already used by AppStream-glib anyway, this doesn't add any actual dependency, just make it direct).
2019-04-13 00:27:38 +08:00
gimp_procedure_add_return_value (procedure,
gimp_param_spec_string ("extension-id",
"ID of installed extension",
"Identifier of the newly installed extension",
FALSE, TRUE, FALSE, NULL,
GIMP_PARAM_READWRITE));
gimp_plug_in_manager_add_procedure (gimp->plug_in_manager, proc);
g_object_unref (procedure);
app, plug-ins: start consolidating brush and pattern loading/saving code We currently have brush and pattern I/O code in both the core and plug-ins. This commit starts removing plug-in code in favor of having one copy of the code in the core, much like XCF loading and saving is implemented. Add app/file-data/ module with file procedure registering code, for now just with an implementation of file-gbr-load. Remove the file-gbr-load code from the file-gbr plug-in.
2019-02-11 19:45:06 +08:00
}
void
file_data_exit (Gimp *gimp)
{
g_return_if_fail (GIMP_IS_GIMP (gimp));
}