dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
gimp/libgimp/gimpresolutionentry-private.h

81 lines
4.2 KiB
C
Raw Normal View History

libgimp: re-promote GimpResolutionEntry in its own file and improve its API. The code comes from plug-ins/common/file-pdf-load.c and apparently it used to be in libgimpwidgets (very long ago). I'm copying it to its own file and massively improve the code (depending on property binding which makes the behavior much more robust). Still I left it as private because I don't want to say the API is finale without having tested it a bit more. But eventually we should make it public for plug-ins to use it directly too. When this happens, it should get back to libgimpwidgets.
2024-04-23 05:54:10 +08:00
/* GIMP - The GNU Image Manipulation Program
* Copyright (C) 1995 Spencer Kimball and Peter Mattis
*
* gimpresolutionentry.h
* Copyright (C) 2024 Jehan
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
#if !defined (__GIMP_UI_H_INSIDE__) && !defined (GIMP_COMPILATION)
#error "Only <libgimp/gimpui.h> can be included directly."
#endif
#ifndef __GIMP_RESOLUTION_ENTRY__
#define __GIMP_RESOLUTION_ENTRY__
G_BEGIN_DECLS
/* For information look into the C source or the html documentation */
/*
* This widget was initially part of libgimpwidgets. Then it got removed and
* moved as private code to file-pdf-load plug-in.
*
* I'm adding it back for GIMP 3 release as its own code but not making it
* public (only to be used by GimpVectorLoadProcedure so far) so that we don't
* have to make sure the API is really right.
*
* TODO: we want to eventually get this back to public API in libgimpwidgets,
* with a much nicer API and also adding a property widget function.
*/
#define GIMP_TYPE_RESOLUTION_ENTRY (gimp_resolution_entry_get_type ())
G_DECLARE_FINAL_TYPE (GimpResolutionEntry, gimp_resolution_entry, GIMP, RESOLUTION_ENTRY, GtkGrid)
typedef struct _GimpResolutionEntry GimpResolutionEntry;
GtkWidget * gimp_prop_resolution_entry_new (GObject *config,
const gchar *width_prop,
const gchar *height_prop,
const gchar *ppi_prop,
const gchar *unit_prop);
GtkWidget * gimp_resolution_entry_new (const gchar *width_label,
gint width,
const gchar *height_label,
gint height,
const gchar *res_label,
gdouble pixel_density,
Issue #8900 and #9923: reimplementing GimpUnit as a proper class. This fixes all our GObject Introspection issues with GimpUnit which was both an enum and an int-derived type of user-defined units *completing* the enum values. GIR clearly didn't like this! Now GimpUnit is a proper class and units are unique objects, allowing to compare them with an identity test (i.e. `unit == gimp_unit_pixel ()` tells us if unit is the pixel unit or not), which makes it easy to use, just like with int, yet adding also methods, making for nicer introspected API. As an aside, this also fixes #10738, by having all the built-in units retrievable even if libgimpbase had not been properly initialized with gimp_base_init(). I haven't checked in details how GIR works to introspect, but it looks like it loads the library to inspect and runs functions, hence triggering some CRITICALS because virtual methods (supposed to be initialized with gimp_base_init() run by libgimp) are not set. This new code won't trigger any critical because the vtable method are now not necessary, at least for all built-in units. Note that GimpUnit is still in libgimpbase. It could have been moved to libgimp in order to avoid any virtual method table (since we need to keep core and libgimp side's units in sync, PDB is required), but too many libgimpwidgets widgets were already using GimpUnit. And technically most of GimpUnit logic doesn't require PDB (only the creation/sync part). This is one of the reasons why user-created GimpUnit list is handled and stored differently from other types of objects. Globally this simplifies the code a lot too and we don't need separate implementations of various utils for core and libgimp, which means less prone to errors.
2024-07-26 02:55:21 +08:00
GimpUnit *display_unit);
libgimp: re-promote GimpResolutionEntry in its own file and improve its API. The code comes from plug-ins/common/file-pdf-load.c and apparently it used to be in libgimpwidgets (very long ago). I'm copying it to its own file and massively improve the code (depending on property binding which makes the behavior much more robust). Still I left it as private because I don't want to say the API is finale without having tested it a bit more. But eventually we should make it public for plug-ins to use it directly too. When this happens, it should get back to libgimpwidgets.
2024-04-23 05:54:10 +08:00
void gimp_resolution_entry_set_width (GimpResolutionEntry *entry,
gint width);
void gimp_resolution_entry_set_height (GimpResolutionEntry *entry,
gint height);
void gimp_resolution_entry_set_pixel_density (GimpResolutionEntry *entry,
gdouble ppi);
void gimp_resolution_entry_set_unit (GimpResolutionEntry *entry,
Issue #8900 and #9923: reimplementing GimpUnit as a proper class. This fixes all our GObject Introspection issues with GimpUnit which was both an enum and an int-derived type of user-defined units *completing* the enum values. GIR clearly didn't like this! Now GimpUnit is a proper class and units are unique objects, allowing to compare them with an identity test (i.e. `unit == gimp_unit_pixel ()` tells us if unit is the pixel unit or not), which makes it easy to use, just like with int, yet adding also methods, making for nicer introspected API. As an aside, this also fixes #10738, by having all the built-in units retrievable even if libgimpbase had not been properly initialized with gimp_base_init(). I haven't checked in details how GIR works to introspect, but it looks like it loads the library to inspect and runs functions, hence triggering some CRITICALS because virtual methods (supposed to be initialized with gimp_base_init() run by libgimp) are not set. This new code won't trigger any critical because the vtable method are now not necessary, at least for all built-in units. Note that GimpUnit is still in libgimpbase. It could have been moved to libgimp in order to avoid any virtual method table (since we need to keep core and libgimp side's units in sync, PDB is required), but too many libgimpwidgets widgets were already using GimpUnit. And technically most of GimpUnit logic doesn't require PDB (only the creation/sync part). This is one of the reasons why user-created GimpUnit list is handled and stored differently from other types of objects. Globally this simplifies the code a lot too and we don't need separate implementations of various utils for core and libgimp, which means less prone to errors.
2024-07-26 02:55:21 +08:00
GimpUnit *unit);
libgimp: re-promote GimpResolutionEntry in its own file and improve its API. The code comes from plug-ins/common/file-pdf-load.c and apparently it used to be in libgimpwidgets (very long ago). I'm copying it to its own file and massively improve the code (depending on property binding which makes the behavior much more robust). Still I left it as private because I don't want to say the API is finale without having tested it a bit more. But eventually we should make it public for plug-ins to use it directly too. When this happens, it should get back to libgimpwidgets.
2024-04-23 05:54:10 +08:00
void gimp_resolution_entry_set_keep_ratio (GimpResolutionEntry *entry,
gboolean keep_ratio);
gint gimp_resolution_entry_get_width (GimpResolutionEntry *entry);
gint gimp_resolution_entry_get_height (GimpResolutionEntry *entry);
gdouble gimp_resolution_entry_get_density (GimpResolutionEntry *entry);
Issue #8900 and #9923: reimplementing GimpUnit as a proper class. This fixes all our GObject Introspection issues with GimpUnit which was both an enum and an int-derived type of user-defined units *completing* the enum values. GIR clearly didn't like this! Now GimpUnit is a proper class and units are unique objects, allowing to compare them with an identity test (i.e. `unit == gimp_unit_pixel ()` tells us if unit is the pixel unit or not), which makes it easy to use, just like with int, yet adding also methods, making for nicer introspected API. As an aside, this also fixes #10738, by having all the built-in units retrievable even if libgimpbase had not been properly initialized with gimp_base_init(). I haven't checked in details how GIR works to introspect, but it looks like it loads the library to inspect and runs functions, hence triggering some CRITICALS because virtual methods (supposed to be initialized with gimp_base_init() run by libgimp) are not set. This new code won't trigger any critical because the vtable method are now not necessary, at least for all built-in units. Note that GimpUnit is still in libgimpbase. It could have been moved to libgimp in order to avoid any virtual method table (since we need to keep core and libgimp side's units in sync, PDB is required), but too many libgimpwidgets widgets were already using GimpUnit. And technically most of GimpUnit logic doesn't require PDB (only the creation/sync part). This is one of the reasons why user-created GimpUnit list is handled and stored differently from other types of objects. Globally this simplifies the code a lot too and we don't need separate implementations of various utils for core and libgimp, which means less prone to errors.
2024-07-26 02:55:21 +08:00
GimpUnit * gimp_resolution_entry_get_unit (GimpResolutionEntry *entry);
libgimp: re-promote GimpResolutionEntry in its own file and improve its API. The code comes from plug-ins/common/file-pdf-load.c and apparently it used to be in libgimpwidgets (very long ago). I'm copying it to its own file and massively improve the code (depending on property binding which makes the behavior much more robust). Still I left it as private because I don't want to say the API is finale without having tested it a bit more. But eventually we should make it public for plug-ins to use it directly too. When this happens, it should get back to libgimpwidgets.
2024-04-23 05:54:10 +08:00
gboolean gimp_resolution_entry_get_keep_ratio (GimpResolutionEntry *entry);
G_END_DECLS
#endif /* __GIMP_RESOLUTION_ENTRY__ */