Clean old // XXX comments

- either removed or changed the comment type
This commit is contained in:
David Benque 2023-12-08 15:10:19 +00:00
parent 56d29ba505
commit fde1edd508
15 changed files with 18 additions and 20 deletions

View File

@ -497,7 +497,7 @@
overflow-x: auto;
}
}
// XXX this might not be the best place for this.
// this might not be the best place for this.
// I just put it next to other "share" styles
// --Aaron
#cp-qr-container {

View File

@ -132,7 +132,7 @@
text {
&.taskText {
&[class*="doneText"], &[class*="activeText"] {
fill: #444 !important; // XXX PR to mermaid or find a suitable variable
fill: #444 !important; // TODO PR to mermaid or find a suitable variable
}
}
&.titleText {

View File

@ -106,7 +106,6 @@
margin-right: 5px;
}
&:hover {
// XXX DB: check hover in light/dark themes
background-color: fade(@cp_toolbar-fg, 30%);
}
&:disabled {

View File

@ -21,7 +21,6 @@
@bg-color: @colortheme_apps[default], // color of the toolbar background
) {
@toolbar-bg-color: @bg-color;
// XXX: check contrasts of app colors used as btn background
@toolbar-bg-color-light: lighten(@bg-color, 30%);
@toolbar-bg-color-fade: fade(@toolbar-bg-color-light, 60%);
};

View File

@ -61,7 +61,7 @@ var decode32 = S => {
};
// XXX Decide expire time
// Decide expire time
// Allow user settings?
var EXPIRATION = 7 * 24 * 3600 * 1000; // Sessions are valid 7 days

View File

@ -804,7 +804,7 @@ var unarchiveChannel = function (env, channelName, cb) {
}
if (exists) {
w.abort();
return CB("UNARCHIVE_METADATA_CONFLICT"); // XXX
return CB("UNARCHIVE_METADATA_CONFLICT");
}
}));
}).nThen(function (w) {

View File

@ -354,14 +354,14 @@
table.cp-block-stats,
table.cp-pin-list,
table.cp-document-stats {
@color: #777; // XXX
@color: #777; // TODO use a colotheme variable
border: 1px solid @color;
margin: 15px;
td, pre {
color: @cryptpad_text_col;
}
td, th {
max-width: 60vw; // XXX
max-width: 60vw;
border: 1px solid @color;
padding: 5px;
.scroll {

View File

@ -1047,9 +1047,9 @@ define([
window.parent.location = href;
});
if (exitable) {
// XXX if true or function, ALSO add a button to leave
// if true or function, ALSO add a button to leave
$(window).focus();
$(window).keydown(function (e) { // XXX what if they don't have a keyboard?
$(window).keydown(function (e) { // what if they don't have a keyboard?
if (e.which === 27) {
e.preventDefault();
e.stopPropagation();

View File

@ -2878,7 +2878,7 @@ define([
if (err.type === 'EEXPIRED') {
msg = Messages.expiredError;
if (err.loaded) {
// XXX You can still use the current version in read-only mode by pressing Esc.
// You can still use the current version in read-only mode by pressing Esc.
// what if they don't have a keyboard (ie. mobile)
msg += Messages.errorCopy;
}
@ -2902,7 +2902,7 @@ define([
});
}
if (err.message && (err.message !== "PASSWORD_CHANGE" || viewer)) {
// XXX If readonly, tell the viewer that their link won't work with the new password
// If readonly, tell the viewer that their link won't work with the new password
UI.errorLoadingScreen(UI.getDestroyedPlaceholder(err.message, false),
exitable, exitable);
return;

View File

@ -7,7 +7,7 @@ var factory = function () {
var Promise = window.Promise;
var cache;
var cypherChunkLength = 131088;
var sendCredentials = window.sendCredentials || false; // XXX SSO find a logical place to infer whether this should be set
var sendCredentials = window.sendCredentials || false; // SSO find a logical place to infer whether this should be set
// Save a blob on the file system
var saveFile = function (blob, url, fileName) {

View File

@ -23,7 +23,7 @@ define([
}).then(response => {
if (response.ok) {
return void response.text().then(result => { CB(void 0, Util.tryParse(result)); }); // XXX checkup error when using .json()
return void response.text().then(result => { CB(void 0, Util.tryParse(result)); }); // checkup error when using .json()
//return void response.json().then(result => { CB(void 0, result); });
}

View File

@ -1254,7 +1254,7 @@ define([
var data = userObject.getFileData(fileId);
if (!data) { return; }
// Don't pin pads owned by someone else
//if (_ownedByOther(Env, data.owners)) { return; } // XXX
//if (_ownedByOther(Env, data.owners)) { return; }
// Pin onlyoffice checkpoints
if (data.lastVersion) {
var otherChan = Hash.hrefToHexChannelId(data.lastVersion);

View File

@ -910,7 +910,7 @@ define([
ctx.sframeChan.on('EV_LOADING_ERROR', function (err) {
var msg = err;
if (err === 'DELETED' || (err && err.type === 'EDELETED')) {
// XXX You can still use the current version in read-only mode by pressing Esc.
// You can still use the current version in read-only mode by pressing Esc.
// what if they don't have a keyboard (ie. mobile)
if (err.type && err.message) {
msg = UI.getDestroyedPlaceholderMessage(err.message, false, true);

View File

@ -296,9 +296,9 @@ define([
},
};
Messages.convertPage = "Convert"; // XXX 4.11.0
Messages.convert_hint = "Pick the file you want to convert. The list of output format will be visible afterwards."; // XXX 4.11.0
Messages.convert_unsupported = "UNSUPPORTED FILE TYPE :("; // XXX
Messages.convertPage = "Convert"; // TODO: hard-coded text since 4.11.0
Messages.convert_hint = "Pick the file you want to convert. The list of output format will be visible afterwards.";
Messages.convert_unsupported = "UNSUPPORTED FILE TYPE :(";
var createToolbar = function () {
var displayed = ['useradmin', 'newpad', 'limit', 'pageTitle', 'notifications'];

View File

@ -293,7 +293,7 @@
}
}
.cp-teams-invite-uses { // XXX
.cp-teams-invite-uses {
input {
margin-bottom: 0px !important;
margin-right: 10px;